perf: add readiness and health probes #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimakis
force-pushed
the
addition-liveness-and-readiness-probes
branch
2 times, most recently
from
1878951 to
2e817ae
Compare
astefanutti
reviewed
Jun 16, 2023
dimakis
force-pushed
the
addition-liveness-and-readiness-probes
branch
2 times, most recently
from
f98f373 to
e775b82
Compare
z103cb
approved these changes
Jun 20, 2023
z103cb
suggested changes
Jun 20, 2023
There was a problem hiding this comment.
Upon further investigation of the build failure, I think this PR needs a bit more attention. Please look into this failure:
2023/06/19 14:18:45 CustomResourceDefinition:/schedulingspecs.mcad.ibm.com created
logger.go:42: 14:18:46 | | running command: [kubectl apply -f test/e2e-kuttl/install-quota-subtree.yaml]
logger.go:42: 14:18:46 | | quotasubtree.ibm.com/context-root created
logger.go:42: 14:18:46 | | quotasubtree.ibm.com/service-root created
logger.go:42: 14:18:46 | | quotasubtree.ibm.com/context-root-children created
logger.go:42: 14:18:46 | | quotasubtree.ibm.com/service-root-children created
logger.go:42: 14:18:46 | | running command: [sh -c helm upgrade --install mcad-controller deployment/mcad-controller --skip-crds --namespace kube-system --wait --set loglevel=${LOG_LEVEL} --set resources.requests.cpu=1000m --set resources.requests.memory=1024Mi --set resources.limits.cpu=4000m --set resources.limits.memory=4096Mi --set image.repository=$IMAGE_REPOSITORY_MCAD --set image.tag=$IMAGE_TAG_MCAD --set image.pullPolicy=$MCAD_IMAGE_PULL_POLICY --set configMap.quotaEnabled='"true"' --set quotaManagement.rbac.apiGroup=ibm.com --set quotaManagement.rbac.resource=quotasubtrees --set configMap.name=mcad-controller-configmap --set configMap.preemptionEnabled='"true"']
logger.go:42: 14:18:47 | | WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/travis/gopath/src/github.com/project-codeflare/multi-cluster-app-dispatcher/kubeconfig
logger.go:42: 14:18:47 | | WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/travis/gopath/src/github.com/project-codeflare/multi-cluster-app-dispatcher/kubeconfig
logger.go:42: 14:18:47 | | Release "mcad-controller" does not exist. Installing it now.
logger.go:42: 14:18:47 | | Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.containers[0]): unknown field "livesnessProbe" in io.k8s.api.core.v1.Container
harness.go:513: cleaning up
harness.go:570: removing temp folder: ""
harness.go:595: fatal error running commands: exit status 1
astefanutti
suggested changes
Jun 20, 2023
dimakis
force-pushed
the
addition-liveness-and-readiness-probes
branch
from
e775b82 to
cc6e404
Compare
dimakis
force-pushed
the
addition-liveness-and-readiness-probes
branch
from
cc6e404 to
f6cbfe7
Compare
z103cb
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked here in the codeflare operator